Skip to content

getContainerByServiceName should work without suffix - #5776

Merged
eddumelendez merged 3 commits into
testcontainers:masterfrom
aidando73:feature/docker-compose-service-name-without-sufix
Aug 31, 2022
Merged

eddumelendez merged 3 commits into
testcontainers:masterfrom
aidando73:feature/docker-compose-service-name-without-sufix

Conversation

@aidando73

@aidando73 aidando73 commented Aug 27, 2022 •

Copy link
Copy Markdown
Contributor

Fixes #5773

@aidando73
aidando73 requested a review from a team August 27, 2022 03:05
@aidando73 aidando73 changed the title getContainerByServiceName should work without sufix getContainerByServiceName should work without suffix Aug 27, 2022
@kiview

kiview commented Aug 29, 2022 •

Copy link
Copy Markdown
Member

Thanks for the PR. The change makes a test in the JUnit5 fail, can you please take a look?
https://github.com/testcontainers/testcontainers-java/runs/8047450685?check_suite_focus=true#step:7:270

@aidando73

Copy link
Copy Markdown
Contributor Author

@kiview 👍, ok build is good. Think it was a flaky test.

@eddumelendez eddumelendez self-assigned this Aug 31, 2022
@eddumelendez eddumelendez added this to the next milestone Aug 31, 2022
@eddumelendez
eddumelendez merged commit fc3d600 into testcontainers:master Aug 31, 2022
@eddumelendez

Copy link
Copy Markdown
Member

thank you so much for your contribution @REslim30 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DockerComposeContainer.getContainerByServiceName not working as expectd

3 participants