Repository navigation
Update localstack images in tests - #5783
Merged
Merged
Conversation
`atlassian/pipelines-awscli` is deprecated and it recommends to use `amazon/aws-cli`. Also, testing against `localstack/localstack:1.0.4`.
Member
Member
Author
|
locally the test pass. However in CI (GHA) I tested with different versions here and it seems that it's failing with versions we are not testing. In the repo attached it fails for |
Member
Author
|
The issue starts using 0.14.3. Just reach out localstack in slack in order to get more info about this due to it only fails in GHA. didn't find anything related by reading the release notes |
Member
|
I think this might be related to the config of the Docker daemon on GHA and it might even be an issue regarding the assumptions of our test. However, obviously there is also some kind of change in the image itself, that triggers this behavior. |
Member
Author
|
in order to do not block this PR I have removed the upgrade for localstack image |
kiview
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atlassian/pipelines-awscliis deprecated and it recommends to useamazon/aws-cli.