Skip to content

Update gitlab_ci.md with clarifying note about the docker host port number - #6063

Merged
kiview merged 1 commit into
testcontainers:mainfrom
BenManifold:patch-1
Oct 26, 2022
Merged

kiview merged 1 commit into
testcontainers:mainfrom
BenManifold:patch-1

Conversation

@BenManifold

Copy link
Copy Markdown
Contributor

Clarity around the port number for unencrypted docker host connections, as most gitlab DinD examples recommend 2736 without explaining why.

Clarity around the port number for unencrypted docker host connections, as most gitlab DinD examples recommend 2736 without explaining why.
@BenManifold
BenManifold requested a review from a team October 25, 2022 15:08

@kiview kiview left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BenManifold, great clarification.

@kiview kiview added this to the next milestone Oct 26, 2022
@kiview
kiview merged commit 46b6cd9 into testcontainers:main Oct 26, 2022
@lack3r

lack3r commented Mar 14, 2023

Copy link
Copy Markdown

Not sure if clarification is indeed required here on that comment.
However, the port shown there should be 2375, and not 2735, and thus the added comment is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants