[monosoul]

On systems with SElinux enforcing trying to bind a path without a context will result in an error. Using shared context by default will make withFileSystemBind(String hostPath, String containerPath) method work for all systems. On Windows, Mac OS and Linux systems without SElinux it will have no effect. On systems with SElinux enforcing it will make the path accessible to the container.

[Flurb]

As an SELinux user, I definitely upvote! Thanks for creating this PR!

[eddumelendez]

Hi, @monosoul, thanks for the PR! Unfortunately, this is a breaking change due to introducing the change will, by default, bind the filesystem instead of copying the file. This will break for those using a remote Docker. Below, you can see the logic described

testcontainers-java/core/src/main/java/org/testcontainers/containers/GenericContainer.java

Lines 1268 to 1284 in 6fe954a

	@Override
	public SELF withClasspathResourceMapping(
	final String resourcePath,
	final String containerPath,
	final BindMode mode,
	final SelinuxContext selinuxContext
	) {
	final MountableFile mountableFile = MountableFile.forClasspathResource(resourcePath);
	if (mode == BindMode.READ_ONLY && selinuxContext == SelinuxContext.NONE) {
	withCopyFileToContainer(mountableFile, containerPath);
	} else {
	addFileSystemBind(mountableFile.getResolvedPath(), containerPath, mode, selinuxContext);
	}
	return self();
	}

However, you still can use the method directly. I understand the PR aim to make this easier. Although, I think we can document this if it is not clear.

[monosoul]

@eddumelendez if shared context will be the default one, I could've just changed the condition there to selinuxContext == SelinuxContext.SHARED. Or am I missing something?

[eddumelendez]

Yes, that's right! 🤦🏽‍♂️ Sorry about that. I just tested locally and with my remote environment and all good.

[eddumelendez]

I'm fine updating addFileSystemBind but with withClasspathResourceMapping, I'm still thinking about it... This will promote copying resources instead of binding filesystem and current source code with those condition will do so. The only scenario to bind filesystem would be with BindMode.READ_WRITE. Ping to @kiview and @bsideup in case I'm missing something.

[eddumelendez]

Superseded by #7187