Skip to content

Improve startup wait checks - #6384

Merged
eddumelendez merged 7 commits into
testcontainers:mainfrom
deejgregor:feature-improve-startup-wait-checks
Mar 28, 2023
Merged

eddumelendez merged 7 commits into
testcontainers:mainfrom
deejgregor:feature-improve-startup-wait-checks

Conversation

@deejgregor

@deejgregor deejgregor commented Jan 4, 2023 •

Copy link
Copy Markdown
Contributor

This has a few small changes related to startup checks:

@deejgregor
deejgregor force-pushed the feature-improve-startup-wait-checks branch from 8f73e44 to 7942109 Compare January 4, 2023 03:13
It's a bit complex, and the ordering in the document happens to
list in reverse the parts of the lifecycle that can be configured.
This makes it more clear without needing to reorder the document.
@deejgregor
deejgregor force-pushed the feature-improve-startup-wait-checks branch from 7942109 to 3cf55ea Compare January 4, 2023 19:31
@deejgregor
deejgregor marked this pull request as ready for review January 6, 2023 17:32
@deejgregor
deejgregor requested a review from a team January 6, 2023 17:32

@eddumelendez eddumelendez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR, @deejgregor ! I've left some comments

Comment thread core/src/main/java/org/testcontainers/containers/GenericContainer.java Outdated
Comment thread docs/features/startup_and_waits.md Outdated
Comment thread core/src/test/java/org/testcontainers/containers/GenericContainerTest.java Outdated
@eddumelendez eddumelendez added this to the next milestone Mar 28, 2023
@eddumelendez
eddumelendez merged commit 2d57f61 into testcontainers:main Mar 28, 2023
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your contribution, @deejgregor ! This will be part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants