Skip to content

Update PR template with more specific wording - #7751

Merged
eddumelendez merged 1 commit into
testcontainers:mainfrom
gvenzl:PR-text-update
Nov 2, 2023
Merged

eddumelendez merged 1 commit into
testcontainers:mainfrom
gvenzl:PR-text-update

Conversation

@gvenzl

@gvenzl gvenzl commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

This PR just adds some more explicit wording for new module contributions into the PR template. As a newcomer, I found the current wording at first a bit confusing, it was clear once I understood which files were meant.

This PR should help other newcomers to not run into any confusion and be more productive.

Signed-off-by: gvenzl <gerald.venzl@gmail.com>
@gvenzl
gvenzl requested a review from a team November 2, 2023 03:36
@eddumelendez eddumelendez added this to the next milestone Nov 2, 2023
@eddumelendez
eddumelendez merged commit b596ae4 into testcontainers:main Nov 2, 2023
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your feedback and contribution, @gvenzl !

@gvenzl

gvenzl commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

You are very welcome!

@gvenzl
gvenzl deleted the PR-text-update branch November 2, 2023 03:57
fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants