Skip to content

Review schemas for possible consolidation and clean-up #1043

Closed

Description

@MVrachev

Description of issue or feature request:
FILEDICT_SCHEMA and TARGETINFO_SCHEMA are doing identical jobs but with the different representations of the information. Just look at their description:
image

image

This issue is based on a discussion with Joshua Lock: #1031 (comment)

Current behavior:
FILEDICT_SCHEMA is used in some functions when it is suitable and TARGETINFO_SCHEMA in other places where it would be easier to use it.

Expected behavior:
I think we should stick to one of those even if it means adding some additional argument to functions and doing little refactoring.

Activity

  1. joshuagl commented on Jun 5, 2020

    @joshuagl
    Member

    We should review the schemas, consolidate and clean up.

    FILEDICT_SCHEMA and TARGETINFO_SCHEMA are clearly serving different purposes, apologies for the bad lead.

    Let's review schemas after #1031 has resolved, as that PR is renaming and cleaning up some of the schemas we are discussing here and makes it hard to reason about where overlap exists.

  2. changed the title [-]Remove FILEDICT_SCHEMA and use only TARGETINFO_SCHEMA instead[/-] [+]Review schemas for possible consolidation and clean-up[/+] on Jun 5, 2020
  3. added this to the milestone on Jul 7, 2020
  4. removed this from the milestone on Sep 8, 2020
  5. jku commented on Feb 16, 2022

    @jku
    Member

    Closing this issue as it was filed against (what is now known as) the legacy codebase: issue seems to not be relevant anymore. Please re-open or file a new issue if you feel that the issue is revelant to current python-tuf.

    The current parsing/validation is likely not perfect but it is far easier to reason about.

    More details

    Current source code (and upcoming 1.0 release) only contains the modern components

    • a low-level Metadata API (tuf.api) and
    • tuf.ngclient that implements the client workflow,

    Legacy components (e.g. tuf.client, tuf.repository_tool, tuf.repository_lib as well as the repo and client scripts) are no longer included. See announcement and API reference for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions