Implement from_object/from_string method in Metadata class #1336

Activity

1. sechkova

   added

   experimental-clientItems related to the development of a new client (see milestone/8 and theexperimental-client branch)Items related to the development of a new client (see milestone/8 and theexperimental-client branch)

   on Apr 7, 2021
2. sechkova

   added this to the Client Refactor milestone on Apr 7, 2021
3. sechkova

   added

   enhancement

   on Apr 7, 2021
4. jku commented on Apr 7, 2021

   

   jku

   on Apr 7, 2021

   Member

   More actions

   I assume this is useful because client does not write new metadata to disk before it's verified so at that point there's only a file-like object but we want to instantiate the Metadata to verify it is correct?

   I guess the other alternative to from_object() is from_string() (and client would then call from_string(tmp_file.read())). I don't think it's clearly better just thinking out loud.
5. sechkova commented on Apr 7, 2021

   

   sechkova

   on Apr 7, 2021

   Last edited by sechkova

   ContributorAuthor

   More actions

   I assume this is useful because client does not write new metadata to disk before it's verified so at that point there's only a file-like object but we want to instantiate the Metadata to verify it is correct?

   Yes, exactly.

   I guess the other alternative to from_object() is from_string() (and client would then call from_string(tmp_file.read())). I don't think it's clearly better just thinking out loud.

   You don't like a function signature with the vague definition of a file object? :)
   String would be ok, raw bytes too, no need to be a file object with its associated methods.

   Now that a separate serialisation was implemented, all we need is basically a method that calls deserialize.
6. sechkova commented on Apr 7, 2021

   

   sechkova

   on Apr 7, 2021

   ContributorAuthor

   More actions

   Something like the existing from_file but without the actual file read from the file system:

     @classmethod
      def from_string/from_bytes/from_raw(
          cls,
          raw_data: str/bytes,
          deserializer: Optional[MetadataDeserializer] = None
      ) -> "Metadata":
   
          if deserializer is None:
              deserializer = JSONDeserializer()
   
          return deserializer.deserialize(raw_data)

   👍React with 👍1Reacted by Jussi Kukkonen
7. joshuagl

   added

   good first issueBite-sized items for first time contributorsBite-sized items for first time contributors

   and removed

   experimental-clientItems related to the development of a new client (see milestone/8 and theexperimental-client branch)Items related to the development of a new client (see milestone/8 and theexperimental-client branch)

   on Apr 13, 2021
8. jku commented on Apr 16, 2021

   

   jku

   on Apr 16, 2021

   Member

   More actions

   looks good to me -- str seems to make sense as type to me
9. jku

   changed the title [-]Implement from_object method in Metadata class[/-] [+]Implement from_object/from_string method in Metadata class[/+] on Apr 16, 2021
10. jku

    self-assigned this

    on Apr 16, 2021
11. jku

    closed this as completedin #1354on Apr 21, 2021