Skip to content

MetaFile/TargetFile: ensure securesystemslib errors are all handled #1452

Description

@jku

Filing this so we can merge #1437 (Add hash and length verification to MetaFile and TargetFile) and can continue with this afterwards.

We need to review the errors that maybe thrown by securesystemslib in in Basefile._verify_hashes():

  • do we want to handle all of them?
  • should we just raise LengthOrHashMismatchError or something else?

My first instinct is that this is like verify_signatures(): the error messages may be interesting but from client POV what matters is that we cannot guarantee that hashes match.

cc @sechkova

Activity

  1. self-assigned this
    on Jun 17, 2021
  2. jku commented on Jun 17, 2021

    @jku
    MemberAuthor

    For reference #1435 is the PR to fix same issue in signature verification

  3. added this to the weeks24-25 milestone on Jun 17, 2021
  4. added
    backlogIssues to address with priority for current development goals
    on Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

backlogIssues to address with priority for current development goals

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions