You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description of issue or feature request:
In #1783 we dropped support for Python 3.6 and inside this pr, we decided to drop OrderedDicts as well: e3b267e.
The argument was that inside python 3.7+ dictionaries insertion order is preserved: https://docs.python.org/3/whatsnew/3.7.html.
Even though the insertion order is preserved we should keep in mind that there are still differences between OrderedDicts and regular dictionaries like when comparing them:
I have implemented __eq__ for all classes inside tuf/api/metadata.py and I have added a separate commit making sure order is considered during comparison where it makes sense: 6ea5372.
That's why I think this issue is resolved.
If there is something to be added, feel free to reopen it.
Activity
MVrachev commentedon Jan 26, 2022
It's good to add solve this issue with #1775.
MVrachev commentedon Feb 28, 2022
I have implemented
__eq__for all classes insidetuf/api/metadata.pyand I have added a separate commit making sure order is considered during comparison where it makes sense: 6ea5372.That's why I think this issue is resolved.
If there is something to be added, feel free to reopen it.