Skip to content

Provide more information when Key.verify_signature() fails #1875

Closed
#1876
Closed
Provide more information when Key.verify_signature() fails#1875
#1876
Assignees
jku
Labels
backlogIssues to address with priority for current development goals
Milestone
sprint 19

Description

@MVrachev
MVrachev
opened on Feb 18, 2022

Current behavior:
If we call Metadata.verify_delegate() and one of the keys fails to be verified the message they got is this:

python-tuf/tuf/api/metadata.py

Line 413 in fc9b42f

logger.info("Key %s failed to verify %s", keyid, delegated_role)

No logging is provided about why the key has failed verification.

Expected behavior:
Adding a log about the last exception message could be useful to provide context for what exactly happened.
This could be useful to identify if a keyvalue is malformed.

Activity

  1. jku
    self-assigned this
    on Feb 21, 2022
  2. jku
    added a commit that references this issue on Feb 21, 2022

    Metadata API: Log details of verify error

    fc1558b
  3. ivanayov
    added this to the sprint 18 milestone on Feb 23, 2022
  4. jku
    linked a pull request that will close this issueLogging and error message improvements #1876on Mar 1, 2022
  5. jku
    modified the milestones: sprint 18, sprint 19 on Mar 9, 2022
  6. jku
    added
    backlogIssues to address with priority for current development goals
    on Mar 9, 2022
  7. jku
    closed this as completedin #1876on Mar 21, 2022
  8. rdimitrov
    added a commit that references this issue on May 10, 2022

    Dimitrovr/test permissions (#14)

    7de325d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

backlogIssues to address with priority for current development goals

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions