Skip to content

Rethink strategy for pinning test dependencies #1899

Closed

Description

@joshuagl

Description of issue or feature request:

Since 5643cec we pin test dependencies in order to improve the determinism of our testing and to prevent test dependency updates from causing CI failures without the PR being tested changing.

Over approximately two weeks we have 9 open PRs from dependabot for test dependencies.

This relatively long list could potentially obfuscate dependot updates in python-tuf dependencies, which we care to address with higher priority.

Furthermore, the level of review rigour required for test dependency updates differs from the that we apply to python-tuf dependency updates.

It may be desirable to alter our approach to pinning test depependencies such that we can reduce the PR load/review implications while preserving the CI/CD determinism.

Current behavior:

Modest PR load on test dependencies which we cannot reasonably review with the same level of depth and rigour as we apply to our library dependencies.

Expected behaviour:

??

Ideas:

  • @jku suggested we might only pin top-level test dependencies
  • we could label test dependencies differently, so that they are easier to filter, by having a different updates entries constrained to the test dependency requirements file.

Activity

  1. jku commented on Mar 15, 2022

    @jku
    Member

    there's a related issue of pinning package build dependencies (see #1269 (comment))

    I'm not sure these have the same solutions at all, just mentioning

  2. added
    discussionDiscussions related to the design, implementation and operation of the project
    on Mar 16, 2022
  3. added this to the Sprint 20 milestone on Mar 23, 2022
  4. added a commit that references this issue on Mar 23, 2022
    ec8a767
  5. added a commit that references this issue on May 10, 2022
    7de325d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

discussionDiscussions related to the design, implementation and operation of the project

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions