Repository navigation
move verify_delegate() from Metadata to Signed #2361
Description
Activity
I thought I had filed this already but failed to find it -- please close if I was dumb and an issue exists already
I thought I had filed this already but failed to find it -- please close if I was dumb and an issue exists already
We discussed this here: #2272 (comment), but I don't think we created an issue.
I'm trying this and it looks like as a result I can also simplify Updater/TrustedMetadataSet a bit:
we currently have accessors like TrustedMetadataSet.root which are used like
consistent_snapshot = trusted_set.root.signed.consistent_snapshot
However, verify_delegate() seems to be the only reason why these accessors are type Metadata, and not the Signed object.Reacted by Joshua LockJust to document how this evolved:
This was the original proposal:
root = repo.root() root.verify_delegate("targets", metadata)that is now actually:
root = repo.root() root.verify_delegate("targets", metadata.signed_bytes, metadata.signatures)So API is a bit more complicated but Root is now not dependent on knowing about Metadata: this is great for future DSSE container format work linked above
verify_delegate() is currently an instance method of Metadata. It could be an instance method of Signed since it does not need anything from metadata and since this would lead to cleaner code.
Metadata:Signed.verify_delegate()and similar code should work:Metadata.verify_delegate()in place as a deprecated method