Repository navigation
Use public key for ed25519 Signer verify method - #297
Merged
Merged
Conversation
Without this patch, the .verify function field in note.Signer uses the Signer's private key to verify a signature, which means the Verifier method returns an unusable verifier. This change fixes the callback to use the correct key. Found and fixed by AI, reviewed by me. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 82.57% 91.79% +9.22%
==========================================
Files 5 10 +5
Lines 241 1097 +856
==========================================
+ Hits 199 1007 +808
- Misses 30 90 +60
+ Partials 12 0 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mhutchinson
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, the
.verifyfunction field innote.Signeruses theSigner's private key to verify a signature, which means theVerifiermethod returns an unusable verifier. This change fixes the callback to use the correct key.Found and fixed by AI, reviewed by me.