Repository navigation
Quote schema and table in SQLAlchemy partitions lookup - #650
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
get_indexes reads the partition columns from the "<table>$partitions" system table, but the query interpolated the schema name unquoted. For a schema name that needs quoting, such as one with a hyphen, the query fails to parse. get_indexes swallows the error and returns no partition index. Build the table reference with the identifier preparer so the schema and table names are always quoted and escaped.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get_indexesreads partition columns from the<table>$partitionssystem table._get_partitionsinterpolated the schema name into that query unquoted and did not escape the table name. For a schema name that needs quoting, such as one with a hyphen, the query fails to parse.get_indexesswallows the error and returns no partition index.This change builds the table reference with the existing
_get_full_tablehelper, which quotes and escapes both identifiers through the dialect's identifier preparer.Tests:
get_indexesnow also runs with thetest-schemaschema.Fixes #649
Non-technical explanation
SQLAlchemy reflection now reports partition columns for Hive tables in schemas whose names contain characters such as hyphens.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: