[pull] master from php:master - #1321
Merged
Merged
Conversation
…ing deprecation Since GH-21699, zend_is_callable_check_class() returns false without setting error when the error handler throws on the self/parent/static deprecation. zend_call_function() asserted that a failed callable check always comes with an error message, so calling such a string callback through call_user_function() (here unserialize_callback_func=parent::...) aborts on debug builds. When the check fails with no error, the exception from the handler is already pending, so zend_call_function() now returns early without throwing a second one, the same way it does when it is entered with an exception. Close GH-23903
* PHP-8.4: Fix GH-23896: Assertion failure in zend_call_function() after a throwing deprecation
* PHP-8.5: Fix GH-23896: Assertion failure in zend_call_function() after a throwing deprecation
* PHP-8.6: Fix GH-23896: Assertion failure in zend_call_function() after a throwing deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )