Repository navigation
File permissions/flags are ignored by filterdiff #59
Description
It seems filterdiff ignores changes in file permissions, such as removal of the executable flag.
Repro:
curl 'https://github.com/NationalSecurityAgency/ghidra/commit/e2a945624b74e5d42dc85e9c1f992315dd154db1.patch' | filterdiffExpected result
A diff
Actual result
Nothing
Activity
sergiomb2 commentedon Feb 6, 2024
is a feature not a bug "This way filterdiff can be used to clean up an existing diff file, removing redundant lines
from the beginning (eg. the text from the mail body) or between the chunks (eg. in CVS diffs). To extract pure patch data"
pbsds commentedon Feb 6, 2024
Not considering file permission changes (nor renames? #22) a part of the "patch data" strikes me as kind of arbitrary, and is unfortunate since it breaks the assumption that a filtered diff would apply the same changes as the original diff.
sergiomb2 commentedon Feb 7, 2024
correct filterdiff clean renames and file permissions modifications from the patch , is a almost an duplicate issue of #22
twaugh commentedon Aug 27, 2025
Please try the PR I just linked.