Repository navigation
Rendering of the 404 page is broken #602
Description
Activity
Hi @armanbilge,
I’m Mannan.
From my understanding of the issue, the root cause seems to be that Laika generates relative paths for assets, which causes the 404 page to break when rendered from arbitrary routes.Wouldn’t this mean that the issue should ideally be addressed in the Laika repository rather than here?
I just wanted to confirm whether this is something that should be fixed upstream, and also i would love to solve this issue could you please assign it me.
@synan-mannan hi, thanks for your interest! Before we assign the issue to you, could you complete the Google Summer of Code onboarding activity? Thank you!
Reacted by Syed Mohammed MannanSure @armanbilge , I have created a PR regarding my onboarding on:
@armanbilge hi, I made a PR in laika to fix this issue. it worked when i test locally and in the html source the 404 page is now having
/main.cssrather thanmain/css. Would really appreciate any feedback, thank you!now:
before:
https://typelevel.org/doesnt/exist
The problem is that Laika generates the HTML for 404.md using relative paths, but the page may be rendered from any path. This may be something that we need to fix upstream in Laika.