how to do command enter and preventing enter from being sent to code editor? #144

Activity

1. jaywcjlove commented on Mar 5, 2023

   

   jaywcjlove

   on Mar 5, 2023

   Member

   More actions

   onKeyDown={(event) => {
   +  event.preventDefault();
     console.log(">>>>");
   }}

   @TheBuilderJR https://codesandbox.io/embed/https-github-com-uiwjs-react-textarea-code-editor-issues-144-4yvoij?fontsize=14&hidenavigation=1&theme=dark
2. aleda145 commented on Mar 5, 2023

   

   aleda145

   on Mar 5, 2023

   More actions

   I was looking at this package, and got the same issue. Linked codesandbox doesn't work for me (using Firefox/Linux (Pop!))
   Enter events will still be sent and be added to the CodeEditor. The same onKeyDown eveent on a normal textarea works as expected though. So might be an issue with how onKeyDown is implemented on the CodeEditor?
3. jaywcjlove commented on Mar 8, 2023

   

   jaywcjlove

   on Mar 8, 2023

   Member

   More actions

   react-textarea-code-editor/src/index.tsx

   Lines 95 to 99 in dedfb99

   	onKeyDown: (evn) => {
   	if (!other.onKeyDown || other.onKeyDown(evn) !== false) {
   	shortcuts(evn);
   	}
   	},

   onKeyDown={(event) => {
   +  event.preventDefault();
     console.log(">>>>");
   +  return true
   }}

   @aleda145 Maybe it can solve your problem
4. aleda145 commented on Mar 8, 2023

   

   aleda145

   on Mar 8, 2023

   More actions

   react-textarea-code-editor/src/index.tsx

   Lines 95 to 99 in dedfb99

   	onKeyDown: (evn) => {
   	if (!other.onKeyDown || other.onKeyDown(evn) !== false) {
   	shortcuts(evn);
   	}
   	},

   onKeyDown={(event) => {
   +  event.preventDefault();
     console.log(">>>>");
   +  return true
   }}

   @aleda145 Maybe it can solve your problem

   It doesn't work :/, same problem. Also tried adding event.stopPropagation();, didn't help either. My enter event is still sent to the codeEditor, creating a new line.

   The following textArea works as expected for me

   <textarea
     onKeyDown={(event) => {
       event.preventDefault();
     }}
   ></textarea>

   Let me know if there anything you want from me to debug this!

   Great package, I still use it! ⭐

   I wanted it to run a SQL query on shift+Enter and not create a new line. But changed to ctrl+space instead, works just as well 😄 !
5. emptycrown commented on Jun 3, 2023

   

   emptycrown

   on Jun 3, 2023

   More actions

   Running into the same issue -- the event cannot be stopped. Any update here?
6. Haiqi-Wu commented on Jun 16, 2023

   

   Haiqi-Wu

   on Jun 16, 2023

   More actions

   Same issue.Any update?
7. jaywcjlove commented on Jun 16, 2023

   

   jaywcjlove

   on Jun 16, 2023

   Member

   More actions

   react-textarea-code-editor/src/index.tsx

   Lines 95 to 99 in dedfb99

   	onKeyDown: (evn) => {
   	if (!other.onKeyDown || other.onKeyDown(evn) !== false) {
   	shortcuts(evn);
   	}
   	},

   onKeyDown={(event) => {
   +  event.preventDefault();
     console.log(">>>>");
   +  return true
   }}

   @aleda145 Maybe it can solve your problem

   Maybe I don't understand what it means, haven't solved the problem yet?

   @emptycrown @Haiqi-Wu @aleda145