Repository navigation
Harden modern port and zone-id parsing - #34
Merged
Merged
Conversation
Reject a port with more than five significant digits before calling int(), so a long digit string in a request header cannot raise ValueError. Zero-padded ports stay valid. Cap IPv6 zone ids at 255 characters in the modern engine only. Legacy is unchanged.
|
Coverage is 98.789% — fix/oversized-port-and-zone into main. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported privately by David Gilman. Thank you.
Test plan
ruff checkon the changed parser and router tests🚀 Generated with Dojo ⛩️