Skip to content

Cargo.toml: merge release-fast profile to release profile - #873

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:patch-1
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:patch-1

Conversation

@oech3

@oech3 oech3 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (015dc1f) to head (4585084).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          35       35           
  Lines        7499     7499           
  Branches      390      390           
=======================================
  Hits         6920     6920           
  Misses        437      437           
  Partials      142      142           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing oech3:patch-1 (4585084) with main (015dc1f)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown

Commit 4585084 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 316 / PASSED: 273 / FAILED: 37 / SKIPPED: 6
  Reference: TOTAL: 317 / PASSED: 274 / FAILED: 37 / SKIPPED: 6

Changes from main branch:
  TOTAL: -1
  PASSED: -1
  FAILED: +0

No result in this run (1) - hung, crashed, or renamed:
  ? posix/depth_error (was PASS)

Comment thread Cargo.toml

[profile.release-fast]
inherits = "release"
panic = "abort"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't only drop release-fast, it enables panic=abort for release (and dist, bfs, gnu builds).
was it intended? if so, please update the title

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@oech3 oech3 changed the title Cargo.toml: drop release-fast profile Cargo.toml: merge release-fast profile to release profile Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants