Repository navigation
Conversation
|
Commit 6a1d94a has test result changes: GNU findutils testsuite: |
b1674e1 to
3099b06
Compare
|
Commit 3f40893 has test result changes: GNU findutils testsuite: |
|
Commit 2d57317 has test result changes: GNU findutils testsuite: |
|
Commit b1674e1 has test result changes: GNU findutils testsuite: |
|
Commit 3099b06 has test result changes: GNU findutils testsuite: bfs testsuite: |
|
Commit 73676e4 has test result changes: GNU findutils testsuite: |
|
Failing CI because of failure of changed tests? |
|
Commit 73676e4 has test result changes: GNU findutils testsuite: |
| cd ../findutils.gnu | ||
| if test ! -f configure; then | ||
| ./bootstrap | ||
| if test ! -f Makefile; then |
There was a problem hiding this comment.
this breaks local runs from a git clone (what line 10 still suggests), there is no configure there.
could you please keep the ./bootstrap step when configure is missing, and update the hint on line 10?
There was a problem hiding this comment.
I think we can hardcode curl tarball to build-gnu.sh for simplicity.
4e3a976 to
631a1ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 35 35
Lines 7576 7576
Branches 393 393
=======================================
Hits 6991 6991
Misses 443 443
Partials 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit 984bf15 has test result changes: GNU findutils testsuite: |
1 similar comment
|
Commit 984bf15 has test result changes: GNU findutils testsuite: |
|
why do you prefer tarball over git clone? |
|
Because git clone + submodule init + bootstrap is very slow and causes many network errors.
GNU's mirror for tarball causes network error too, but still better than git.
We really should have our own mirror of tarballs.
|
Closes #878