Conversation
- Add numeric_column_test.go and 5 others - Update field.go and 20 others Generated with Codg Assisted-by: claude-fable-5-1 via Codg <codg@atomai.cc>
- Update config.go Generated with Codg Assisted-by: claude-fable-5-1 via Codg <codg@atomai.cc>
|
|
There was a problem hiding this comment.
🟡 Changes recommended
A new regression test fails after deletion, and scratch/reset changes can corrupt nested aggregations or retain substantial memory.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds typed numeric column reads and configurable ICE stored-chunk caching, with related benchmarks, compatibility handling, and tests.
Changes:
- Routes numeric, date, and geo values through typed doc-value visitors.
- Adds reusable numeric prefix encoding and match scratch buffers.
- Adds stored-chunk cache configuration and ICE version compatibility.
File summaries
| File | Description |
|---|---|
stats_bench_test.go |
Adds columnar aggregation benchmarks. |
search/source.go |
Reads typed numeric values. |
search/search.go |
Stores typed values and scratch buffers. |
search/aggregations/terms.go |
Optimizes bucket lookup. |
numeric/prefix_coded.go |
Adds append-based encoding. |
numeric_column_test.go |
Tests numeric-column aggregations. |
index/snapshot.go |
Supports typed document-value visits. |
index/config.go |
Adds cache configuration and plugin registration. |
index/config_test.go |
Tests cache configuration. |
go.sum |
Updates dependency checksums. |
go.mod |
Updates segment dependencies. |
field.go |
Exposes numeric field values. |
config.go |
Exposes cache configuration publicly. |
Review details
- Files reviewed: 12/13 changed files
- Comments generated: 7
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+114
to
+115
| if got := aggs.Metric("min"); got != -201 { // -100.5 * 2 | ||
| t.Fatalf("min %v", got) |
Comment on lines
+163
to
+167
| dm.termScratch = dm.termScratch[:0] | ||
| dm.termBytes = dm.termBytes[:0] | ||
| for _, n := range dm.docNumbers { | ||
| if n.field != field { | ||
| continue |
Comment on lines
+94
to
+98
| rv := match.numScratch[:0] | ||
| if match.hasDocNumbers(string(f)) { | ||
| for _, n := range match.docNumbers { | ||
| if n.field == string(f) { | ||
| rv = append(rv, numeric.Int64ToFloat64(n.value)) |
Comment on lines
+210
to
+211
| for k, v := range dm.docValues { | ||
| dm.docValues[k] = v[:0] |
- Add numeric_nested_test.go, value_lifetime_test.go - Update numeric_column_test.go and 4 others Generated with Codg Assisted-by: gpt-6-astra via Codg <codg@atomai.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide Issues links to:
Provide test code:
Description
...