Repository navigation
Allow Logger objects to have their levels set - #2
Open
noelleleigh wants to merge 1 commit into
Open
noelleleigh wants to merge 1 commit into
noelleleigh wants to merge 1 commit into
Conversation
If `loglevelDebug` is passed a Logger object, it will now get added to the `_loggers` object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current broken behavior
When
loglevelDebug()is passed an Object (rather than a String) andDEBUGis truthy, the logger won't have its level set inenable()because it won't appear in the_loggersobject.New behavior
If
loglevelDebug()is passed an Object, it will now get added to the_loggersobject.