Repository navigation
Test exact one-year formatting boundary - #302
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
A strict
>comparison at exactly 365.25 days would format one year as12morather than1y. The new cases protect the equality boundary in short and long formats for both signs.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Change and verification
Summary
Test the exact one-year threshold in both short and long formatting, for positive and negative values. Existing year tests use a value one millisecond above the threshold, so they do not protect the comparison at equality.
Regression proof
In an isolated worktree, changing both year checks from
>=to>left the unchanged Node.js and Edge suites green (167 tests in each). With this test added, the same regression fails by assertion: exactly one year formats as12moinstead of1y. Restoring production code passes both suites (168 tests in each).Verification
pnpm lint— passedpnpm typecheck— passedbiome ci src/format.test.ts— passedpnpm test— 168 tests passed in Node.js and 168 in Edgegit diff --check— passedThe permanent diff is limited to
src/format.test.ts.Repository guidance
No contribution guide or PR template was present in the audited checkout. The project lint, typecheck, Biome check, and Node/Edge tests passed.