Repository navigation
fix: prevent executable planting during sfw lookup - #190
Merged
Merged
Conversation
fengmk2
force-pushed
the
fix/sfw-path-lookup
branch
from
October 8, 2026 06:02
e58b235 to
6b4f5ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sfwis enabled, command lookup can execute a repository-controlled program. Later lookup of the baresfwname can also select a rejected workspace binary.Find native executables directly in fully qualified
PATHdirectories. Exclude empty and relative entries, including Windows paths without a drive or UNC share. Compare filesystem identities to exclude all aliases of the current directory, including case aliases on case-insensitive volumes.Carry the selected absolute path into dependency installation and retries for GitHub Actions, GitLab CI/CD, and Azure Pipelines. Use the same path handling for downloaded and cached binaries. Keep the decision to prepend the
vpargument separate from the executable path.