Skip to content

fix(migrate): preserve Oxlint inheritance with shared TS configs - #3097

Draft
fengmk2 wants to merge 9 commits into
mainfrom
fix/migrate-oxlint-extends
Draft

fengmk2 wants to merge 9 commits into
mainfrom
fix/migrate-oxlint-extends

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

vp migrate copies JSON extends paths into lint.extends, but vp lint requires config objects.

The migrator now creates shared TypeScript configs and imports them, including nested inheritance. All migrated consumers, including the owning workspace, import the same module. Shared rule edits apply to every consumer. Migration defaults stay in each workspace's local lint block. Rule order, severities, overrides, and explicit options remain intact.

The owner references its shared ignorePatterns at the top level. Other consumers keep their own exclusions. Plugin declarations stay in their original config or override. Relative plugin paths resolve from import.meta.url. Original shared JSON files remain available to other consumers.

Conflicts or unsupported configs leave the original JSON in place with a warning. Workspace cleanup waits until all migration outcomes are known. Each workspace must complete its own merge before cleanup can remove its JSON path, even when multiple symlinks share a source. Cleanup retains the transitive JSON dependencies of preserved consumers and symlink targets.

Fixes #3089

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-migrate-oxlint-extends-viteplus-dev.voidzero-docs.workers.dev (commit 5973b90)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f9b997c3-viteplus-dev.voidzero-docs.workers.dev 5973b90 2026-10-18T11:12:54.239Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9c09b3e0-viteplus-dev.voidzero-docs.workers.dev eda4fca 2026-10-18T10:40:08.246Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2168e45b-viteplus-dev.voidzero-docs.workers.dev 984f924 2026-10-18T08:14:27.653Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://97d60657-viteplus-dev.voidzero-docs.workers.dev f58eeb3 2026-10-18T07:22:20.846Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://32716c0a-viteplus-dev.voidzero-docs.workers.dev 3d79452 2026-10-18T05:06:02.283Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ff8ef7c1-viteplus-dev.voidzero-docs.workers.dev cac98a4 2026-10-18T03:59:05.107Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9d884f02-viteplus-dev.voidzero-docs.workers.dev 0877f9f 2026-10-17T17:12:03.454Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2ff7dcab-viteplus-dev.voidzero-docs.workers.dev 3b7e402 2026-10-17T17:08:57.589Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a953bc20-viteplus-dev.voidzero-docs.workers.dev bf0e041 2026-10-17T16:55:53.134Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a08881c2-viteplus-dev.voidzero-docs.workers.dev 843a5ff 2026-10-17T07:44:21.554Z Visit the dashboard ↗

View all previews: View all previews ↗

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 5973b90

@fengmk2 fengmk2 changed the title fix(migrate): resolve Oxlint JSON extends fix(migrate): preserve Oxlint inheritance with shared TS configs Oct 17, 2026
@fengmk2
fengmk2 force-pushed the fix/migrate-oxlint-extends branch from bf0e041 to 3b7e402 Compare October 17, 2026 17:07
@fengmk2
fengmk2 force-pushed the fix/migrate-oxlint-extends branch from 0877f9f to cac98a4 Compare October 18, 2026 03:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vp migrate copies string extends paths from .oxlintrc.json into lint, which vp lint rejects

1 participant