Repository navigation
Account for interleaved samples in Compute Layout and Allocation Size - #962
Merged
Merged
Conversation
The pixel format definitions use "sample" for a single component value (an NV12 UV element is "composed of two Chroma samples", and an RGBA pixel is four 8-bit samples). Compute Layout and Allocation Size used the number of bytes per sample as the size of each position in a plane, which undercounts planes that interleave several components: sourceLeftBytes and sourceWidthBytes were half the correct value for the NV12 UV plane and a quarter for RGBA, RGBX, BGRA and BGRX. Multiply the bytes per sample by the number of samples stored at each position of the plane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #961
The pixel format definitions use "sample" for a single component value (an NV12 UV element is "composed of two Chroma samples", and an RGBA pixel is four 8-bit samples). Compute Layout and Allocation Size used the number of bytes per sample as the size of each position in a plane, which undercounts planes that interleave several components: sourceLeftBytes and sourceWidthBytes were half the correct value for the NV12 UV plane and a quarter for RGBA, RGBX, BGRA and BGRX.
Multiply the bytes per sample by the number of samples stored at each position of the plane.
Preview | Diff