Repository navigation
Round up sub-sampled width in Compute Layout and Allocation Size - #964
Merged
Merged
Conversation
Step 9 computed sourceWidthBytes using the integer division of the rect width by the horizontal sub-sampling factor, while step 7 rounds the sub-sampled height up and the pixel format definitions round both dimensions up. For a rect with an odd width, this dropped the last chroma column: a 3x3 I420 frame got a chroma stride of 1 and an allocation size of 13 instead of 2 and 17, as expected by webcodecs/videoFrame-odd-size.any.js. Round the division up, matching step 7. Fixes w3c#963
github-actions Bot
added a commit
that referenced
this pull request
Oct 7, 2026
SHA: 6f4d6eb Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 9 computed sourceWidthBytes using the integer division of the rect width by the horizontal sub-sampling factor, while step 7 rounds the sub-sampled height up and the pixel format definitions round both dimensions up. For a rect with an odd width, this dropped the last chroma column: a 3x3 I420 frame got a chroma stride of 1 and an allocation size of 13 instead of 2 and 17, as expected by
webcodecs/videoFrame-odd-size.any.js.
Round the division up, matching step 7.
Fixes #963
Preview | Diff