Repository navigation
Auto-refresh file preview when the file changes on disk #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NGdev2
wants to merge
2
commits into
wavetermdev:main
Choose a base branch
from
NGdev2:feat/preview-auto-refresh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: wavetermdev/waveterm
Length of output: 41841
🏁 Script executed:
Repository: wavetermdev/waveterm
Length of output: 16391
🏁 Script executed:
Repository: wavetermdev/waveterm
Length of output: 13766
Do not mark a streaming reload successful before the stream loads.
If the browser stream request fails,
didReloadSucceed()still returnstruefor"streaming".checkForExternalChange()then records the new modification time, and later polls stop issuing new stream URLs. Keep the modification time eligible for retry until the streaming element reports a successful load.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep this as is. For streamed previews the retry wouldn't help much: for local files a failed load almost always means the file itself is invalid (retrying shows the same broken image again), and for PDFs the <iframe> fires load even on an HTTP error, so failure can't be detected reliably anyway. Wiring load/error events from the img/video/iframe elements back into the model would add complexity across several files for this edge case. The manual refresh button still works as a fallback. Happy to revisit if the maintainers prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NGdev2, thanks for the guidance. An<iframe>load event does not reliably confirm a successful PDF load, so the proposed event wiring would not cover all streamed previews.Keeping automatic streaming refresh best-effort, with manual refresh as a fallback, is a reasonable trade-off. Transient load failures remain a limitation, but I won't press for this change in this PR.
✏️ Learnings added
You are interacting with an AI system.