Repository navigation
build: move from npm to pnpm 11 - #2273
Merged
Merged
Conversation
Use pnpm 11.27.1, the same as WebdriverIO v10. pnpm-lock.yaml is imported from package-lock.json, so the versions do not change. pnpm does not hoist, which shows two gaps that npm hid: - @types/deep-eql came from another package: now a dev dependency - @wdio/globals installed expect-webdriverio 6.0.9 as its peer, and its global types merged with ours: override it to this package, as the playgrounds already do The type error filter now also matches the pnpm node_modules paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- playgrounds/pnpm-workspace.yaml lists the packages, links expect-webdriverio to the root (link:.., in place of file:.. and the npm override) and declares the ignored install scripts - pnpm-lock.yaml is imported from package-lock.json, and the extra multi-remote-mocha lock file is removed - declare the packages that npm hoisting hid: the typescript-eslint parser and plugin (used by every ESLint config), and @wdio/mocha-framework and vue in browser-runner - pnpm passes `--` to the script, so the Mocha snapshots:update script no longer uses it (else wdio ignored --spec and ran every spec) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pnpm/action-setup v6.0.10 (the same as WebdriverIO) before setup-node, and pnpm install --frozen-lockfile - the release no longer uses --force: pnpm peers check finds no conflict - pnpm --filter in place of npm --workspace, without `--` - AGENTS.md, the verify skill, the PR template, the Copilot instructions and the playground README use pnpm Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`test` already runs the type tests (`test:types` = `ts` and `tsc:root-types`), and `build` already compiles, so checks:all ran compile, tsc:root-types and every type test project twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a terminal, color codes surround each diff line, so a pattern over two lines did not match and the playground failed outside the CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
src/ imports types from them, but only webdriverio depended on them. npm hoisted them; pnpm does not, so the CI build failed. Locally, a node_modules folder above the repository hid the error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wdio/browser-runner makes Vite pre-bundle some CommonJS packages (optimizeDeps.include), and Vite looks for them from the project root. pnpm does not hoist them, so the browser loaded raw CommonJS and failed with "does not provide an export named 'default'". p-iteration is left out: no package installs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dprevost-LMI
marked this pull request as ready for review
September 28, 2026 11:13
Contributor
|
Match the two diff lines in order again, on the message without the terminal color codes (strip-ansi, as the unit tests use). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2247 (Tooling: "Move from npm to pnpm 11, the same as WebdriverIO")
WebdriverIO v10 uses pnpm 11. This PR moves the package, the playgrounds and the CI from npm to pnpm 11.27.1, the same version as WebdriverIO.
Changes
Root package
packageManager: pnpm@11.27.1.pnpm-lock.yamlis imported frompackage-lock.json(pnpm import), so no version changespnpm-workspace.yaml:allowBuildsset tofalseforedgedriver,esbuildandgeckodriver, the same as WebdriverIO (the drivers are downloaded at runtime)pre-commithook use pnpmPlaygrounds
playgrounds/pnpm-workspace.yaml) in place of npm workspacesexpect-webdriverioislink:..(wasfile:..plus an npmoverridesentry)multi-remote-mocha/package-lock.jsonis removedCI and docs
pnpm/action-setupv6.0.10 (pinned, the same as WebdriverIO) andpnpm install --frozen-lockfilenpm ci --force:pnpm peers checkfinds no conflictpnpm --filter ./<playground>in place ofnpm --workspace=<playground>Problems that npm hoisting hid
@types/deep-eqlcame from another package@wdio/globalsinstalledexpect-webdriverio6.0.9 as its peer, and its global types merged with oursoverrides: expect-webdriverio: link:., as the playgrounds already donode_modules/.pnpm/...pathsnode_modules/<package>@typescript-eslint/*, but no playground declared itbrowser-runnerused@wdio/mocha-frameworkandvuewithout declaring thembrowser-runner--to the script (npm removes it), sowdioignored--specand--exclude--in the Mochasnapshots:updatescript and in the CIChecks
pnpm run checks:allafter a clean install: 50 test files, 2,541 testsnpm pack --dry-runandpnpm pack --dry-run)pnpm exec release-itcomputes the same next version (8.0.0-alpha.0)Notes
npmecosystem also reads pnpm 11 lock files. Check after the merge that it still opens update PRs.@wdio/browser-runnerlogsoptimizeDeps.includewarnings (lodash.mergeand others) with pnpm. They are only warnings, and the tests pass.@wdio/types, which is only a dev dependency, so pnpm users cannot resolve it. Planned with [v8] Require WebdriverIO v10 and Node.js 22.19, and release v8 together with WebdriverIO v10 #2246.minimumReleaseAge). This matters for the v8 alpha and the WebdriverIO v10 prereleases.🤖 Generated with Claude Code