Make this action work on Windows as well

[Raynos]

When using this github action on windows it's not happy as off two days ago.

I currently get the error

unable to start ssh-agent service, error :1058

I am currently trying to figure out what changed on windows 2019 on github actions ...

[Raynos]

I spend a full day trying to figure this out.

The following works for me.

    # The webfactory/ssh-agent module does not work on Windows anymore
    # I do not recommend touching this SSH stuff, i spend two days
    # tweaking it just to get it to work on windows -.-
    - name: Configure SSH
      run: Set-Service ssh-agent -StartupType Manual
    - name: Start SSH
      run: Start-Service ssh-agent
    - name: Add SSH key
      run: echo $env:SSH_PRIVATE_KEY | ssh-add -
      env:
        SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
    - name: Add github.com to known_hosts
      run: |
        mkdir ~/.ssh
        ssh-keyscan github.com >> ~/.ssh/known_hosts
    - name: Use Node.js
      uses: actions/setup-node@v1
      with:
        node-version: 10.x
    - name: npm install
      run: |
        git config --global core.sshCommand "'C:\Windows\System32\OpenSSH\ssh.exe'"
        npm ci

The important parts are to start the other SSH agent ... and to configure git to use the other SSH agent ...

Obvouisly node & npm are unrelated to ssh-agent but I only use ssh-agent for npm when it tries to git clone private github repositories.

[Raynos]

actions/runner-images@8185a8b

Yeah this makes sense to me now why it's broken.

[mpdude]

As per the README, Windows isn’t even supported by this action.

But if it is possible to get it to work, open a PR!

[Raynos]

Windows actually worked just fine out of the box a week ago.

[mpdude]

Can it be that the ssh-agent has automatically been running in the background?

[Raynos]

I searched about this issue. There’s lots of discussions about a breaking changes in some windows 10 update from mid 2018

It sounds like there was a change in the ssh behavior between windows and git.

[mpdude]

@Raynos can you keep us updated here with instructions what is the "right" way to start and/or stop the ssh-agent on Windows?

Maybe we then can find someone to implement Windows support as well.

[Raynos]

The steps I’ve listed above work for me on windows.

[mpdude]

If anybody can help getting this to run, join #17.