You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
WebNN's WPT test seems blocking the CL submission of Model Loader API #31
@yuhonglin Since there're common ML and MLContext interfaces in both WebNN and Model loader API, this would make some WebNN IDL tests pass in your CL, glad to see you found the solution.
BTW, we think you could also add IDL tests of Model Loader API into WPT, what's your plan for it?
Yes, "adding Model loader test to WPT" is on our todo list but is not of high priority. We currently lack bandwidth so, many things are moving slower (including my replies on Github :) ) than expected. Sorry.
Activity
yuhonglin commentedon Mar 23, 2022
@huningxin Can we disable that test temporarily?
yuhonglin commentedon Mar 23, 2022
No worries for now. It seems we can disable it in chrome: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=1?q=TestExpectations&sq=&ss=chromium
huningxin commentedon Mar 23, 2022
good to know it won't block model loader. /cc @BruceDai who is working on WebNN WPT.
yuhonglin commentedon Mar 23, 2022
Never mind. We will update the "expectation" of the test output to make it pass the chromium cq. It seems a common practice to do so.
BruceDai commentedon Apr 12, 2022
@yuhonglin Since there're common ML and MLContext interfaces in both WebNN and Model loader API, this would make some WebNN IDL tests pass in your CL, glad to see you found the solution.
BTW, we think you could also add IDL tests of Model Loader API into WPT, what's your plan for it?
yuhonglin commentedon Apr 13, 2022
Yes, "adding Model loader test to WPT" is on our todo list but is not of high priority. We currently lack bandwidth so, many things are moving slower (including my replies on Github :) ) than expected. Sorry.