Repository navigation
Conversation
got 15+ returns Uint8Array for responseType 'buffer' and doesn't allow url in options object. Pass url as first argument and convert response body to Buffer so afterResponse handlers keep receiving Buffer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aivus
added a commit
that referenced
this pull request
Oct 19, 2026
Resolve conflicts with the got v16 update (#665): - pass url to got.stream separately, v16 no longer allows url in options - accept Uint8Array body from afterResponse - drop master's transformResult tests, the function no longer exists - combine both "From version 6 to 7" migration sections Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #661.
got 15 and 16 have breaking changes that affect the scraper, so the dependabot bump alone fails 60 tests:
urlis no longer allowed in the options object.getRequestnow callsgot(url, options). Aurlin userrequestoptions now makes got throw (seeMIGRATION.md).responseType: 'buffer'returns aUint8Arrayinstead of aBuffer.transformResultcheckedinstanceof Bufferand threw "Wrong response handler result". The response body is now converted to aBuffer(without copying) before it goes toafterResponse, so user handlers keep getting aBuffer.transformResultalso accepts anyUint8Array.MIGRATION.mdhas a new v6 → v7 section covering the Node 22 requirement and the got changes users can see throughoptions.request:strictContentLengthon by default, 300/304 no longer followed, removed options, HTTP/2 and DNS cache changes, and credentials stripped on cross-origin redirects from hooks.Tests: 248 passing, including new tests for a
Uint8Arraybody and forafterResponsereceiving aBuffer.🤖 Generated with Claude Code