Skip to content

[3단계 - JSON View 구현하기] 누누(이재혁) 미션 제출합니다. - #1351

Open
LEEJaeHyeok97 wants to merge 17 commits into
woowacourse:LEEJaeHyeok97from
LEEJaeHyeok97:step3
Open

LEEJaeHyeok97 wants to merge 17 commits into
woowacourse:LEEJaeHyeok97from
LEEJaeHyeok97:step3

Conversation

@LEEJaeHyeok97

Copy link
Copy Markdown
Member

MVC 미션 마지막 단계네요

이번 MVC 과정을 학습하면서 어떤 흐름으로 JSON을 우리 애플리케이션 서버에서 주게되었는지 배울 수 있어서 즐거웠습니다~!

마지막 리뷰도 잘부탁드려요~

@jason0904 jason0904 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 누누!
3단계 구현 잘해주셨네요!
요구사항은 대부분 충족한거 같아 Approve합니다!
하나 걸리는 부분이 있는데, 그 부분만 수정하고 머지하면 좋을 것 같습니다!
jdbc 미션도 파이팅입니다!

controllers.put("/login", new LoginController());
controllers.put("/login/view", new LoginViewController());
controllers.put("/logout", new LogoutController());
controllers.put("/register/view", new RegisterViewController());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 엔드포인트의 매핑이 현재 RegisterController에는 없는데, 이러면 이 엔드포인트로 접근을 하면 Exception이 터지는 문제가 발생할 거 같네요..!

final var session = req.getSession();
session.removeAttribute(UserSession.SESSION_KEY);
return "redirect:/";
return new ModelAndView(new JspView("redirect:/"));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return new ModelAndView(new JspView("redirect:/"));
return new ModelAndView(new JspView(JspView.REDIRECT_PREFIX + "/"));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants