Skip to content

chore(deps): Replace jszip with fflate - #2542

Closed
aklinker1 wants to merge 2 commits into
mainfrom
fflate
Closed

aklinker1 wants to merge 2 commits into
mainfrom
fflate

Conversation

@aklinker1

@aklinker1 aklinker1 commented Jul 31, 2026 •

Copy link
Copy Markdown
Member

Overview

Apart of #2523. 20MB / 139 packages → 19MB / 127 packages

Manual Testing

  • Does chrome accept these zips?
    • Yes, on Mac at least
  • Does it work with a compression level of zero?
    • Yes, demo project is 269.24 kB in build output, zip is 266 kB.
  • Are the zip sizes comparable?
    • 97.65 kB on main, 98.23 kB on this PR
  • What about time it takes to build the zip?
    • 53 ms on main, 65 ms on this PR
  • Memory used? /usr/bin/time -v bun zip
    • 415912 on main, 366556 on this PR

@netlify

netlify Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit a7d6b2d
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a6cc08c6377d90008bb7b5f
😎 Deploy Preview https://deploy-preview-2542--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Jul 31, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2542

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2542

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2542

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2542

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2542

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2542

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2542

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2542

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2542

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2542

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2542

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2542

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2542

wxt

npm i https://pkg.pr.new/wxt@2542

commit: a7d6b2d

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.19%. Comparing base (5a1a5a1) to head (a7d6b2d).

Files with missing lines Patch % Lines
packages/wxt/src/core/zip.ts 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
+ Coverage   79.05%   79.19%   +0.14%     
==========================================
  Files         133      133              
  Lines        3981     3990       +9     
  Branches      925      927       +2     
==========================================
+ Hits         3147     3160      +13     
+ Misses        737      735       -2     
+ Partials       97       95       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1

Copy link
Copy Markdown
Member Author

Closing in favor of #2538, see #2523 (comment)

@aklinker1 aklinker1 closed this Jul 31, 2026
@PatrykKuniczak
PatrykKuniczak deleted the fflate branch October 11, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant