Skip to content

Bad use of OutOfMemoryError to validate buffer size #629

Closed
Closed
Bad use of OutOfMemoryError to validate buffer size#629

Description

@duongkame
duongkame
opened on Jan 8, 2025

In SnappyInputStream, OutOfMemoryError is used to validate the buffer size to allocated.

snappy-java/src/main/java/org/xerial/snappy/SnappyInputStream.java

Lines 451 to 456 in dfbf67a

try {
compressed = new byte[chunkSize];
}
catch (java.lang.OutOfMemoryError e) {
throw new SnappyError(SnappyErrorCode.INVALID_CHUNK_SIZE, e.getMessage());
}

This's a bad way to validate buffer size as explain here.
And another serious consequence, catching OutOfMemoryError in Java code requires the applications not to use JVM options like CrashOnOutOfMemoryError or ExitOnOutOfMemoryError to automatically restart the JVM when it runs out of memory.

I'm wondering if there is a specific reason why that could not be a simple conditional validation?

Activity

  1. xerial commented on Feb 4, 2025

    @xerial
    xerial
    on Feb 4, 2025
    Owner

    There wasn't any specific reason for that. It's better to be fixed as you suggested.

  2. duongkame commented on Feb 26, 2025

    @duongkame
    duongkame
    on Feb 26, 2025
    ContributorAuthor

    Thanks for your reply @xerial. I filed a PR: https://github.com/xerial/snappy-java/pull/647/files.

  3. xerial commented on Jul 20, 2025

    @xerial
    xerial
    on Jul 20, 2025
    Owner

    Fixed in #647. Thanks!

  4. xerial
    closed this as completedon Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions