Skip to content

Suppress AccessController deprecation warning for Java 17+ #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 2 commits into from
Jul 20, 2025
Merged

Suppress AccessController deprecation warning for Java 17+ #682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58b3491
Suppress AccessController deprecation warning
xerial Jul 20, 2025
e30b4b4
Apply @SuppressWarnings to specific methods instead of class level
xerial Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/xerial/snappy/pool/DirectByteBuffers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ final class DirectByteBuffers {
// and https://github.com/apache/lucene-solr/blob/7e03427fa14a024ce257babcb8362d2451941e21/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
MethodHandle cleanHandle = null;
try {
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
final PrivilegedExceptionAction<MethodHandle> action = new PrivilegedExceptionAction<MethodHandle>() {

@Override
Expand Down Expand Up @@ -90,7 +91,9 @@ public MethodHandle run() throws Exception {
}
};

cleanHandle = AccessController.doPrivileged(action);
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
MethodHandle temp = AccessController.doPrivileged(action);
cleanHandle = temp;

} catch (Throwable t) {
Logger.getLogger(DirectByteBuffers.class.getName()).log(Level.FINE, "Exception occurred attempting to lookup Sun specific DirectByteBuffer cleaner classes.", t);
Expand Down Expand Up @@ -121,6 +124,7 @@ static boolean nonNull(Object o) {
*
* @param buffer The {@code ByteBuffer} to release. Must not be {@code null}. Must be {@link ByteBuffer#isDirect() direct}.
*/
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
public static void releaseDirectByteBuffer(final ByteBuffer buffer)
{
assert buffer != null && buffer.isDirect();
Expand Down