Skip to content

Feature implementation from commits 78edcb9..1b9b9bb - #1

Open
yashuatla wants to merge 15 commits into
feature-base-1from
feature-head-1
Open

yashuatla wants to merge 15 commits into
feature-base-1from
feature-head-1

Conversation

@yashuatla

@yashuatla yashuatla commented Jun 24, 2025 •

Copy link
Copy Markdown
Owner

PR Summary

Add Nested Pipe Verbose Script and Update Tests

Overview

This PR adds a new Node.js script for handling command execution with piping and updates related test files for the verbose subprocess functionality.

Change Types

Type Description
Feature New script for command execution with piping
Enhancement Improved test coverage for verbose subprocess functionality
Bugfix Fixed test expectation in error handling test

Affected Modules

Module / File Change Description
fixtures/nested-pipe-verbose.js New script for command execution with piping
verbose/custom-options.js New test for runVerboseSubprocess with different options
verbose/error.js Updated test expectation for error handling

Comment thread test/verbose/error.js
const testPrintErrorEarly = async (t, isSync) => {
const stderr = await runEarlyErrorSubprocess(t, isSync);
t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`);
t.is(getErrorLine(stderr), undefined);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 Correctness Issue

Test expectation contradicts test purpose.

The test named 'Prints early validation error' now expects no error (undefined), which contradicts its purpose and could mask real errors.

Current Code (Diff):

- 	t.is(getErrorLine(stderr), undefined);
+ 	t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`);
📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change
t.is(getErrorLine(stderr), undefined);
t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants