Repository navigation
Conversation
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
| const testPrintErrorEarly = async (t, isSync) => { | ||
| const stderr = await runEarlyErrorSubprocess(t, isSync); | ||
| t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`); | ||
| t.is(getErrorLine(stderr), undefined); |
There was a problem hiding this comment.
🐛 Correctness Issue
Test expectation contradicts test purpose.
The test named 'Prints early validation error' now expects no error (undefined), which contradicts its purpose and could mask real errors.
Current Code (Diff):
- t.is(getErrorLine(stderr), undefined);
+ t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`);📝 Committable suggestion
‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀
Suggested change
| t.is(getErrorLine(stderr), undefined); | |
| t.is(getErrorLine(stderr), `${testTimestamp} [0] × TypeError: The "cwd" option must be a string or a file URL: true.`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Nested Pipe Verbose Script and Update Tests
Overview
This PR adds a new Node.js script for handling command execution with piping and updates related test files for the verbose subprocess functionality.
Change Types
Affected Modules
fixtures/nested-pipe-verbose.jsverbose/custom-options.jsrunVerboseSubprocesswith different optionsverbose/error.js