Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Should fix station goals never triggering - #22856

Merged
ToasterBiome merged 5 commits into
yogstation13:masterfrom
Moltijoe:StorytellerSendIntercept
Dec 20, 2024
Merged

ToasterBiome merged 5 commits into
yogstation13:masterfrom
Moltijoe:StorytellerSendIntercept

Conversation

@Moltijoe

Copy link
Copy Markdown
Contributor

It never called the station goal report so it never enabled the purchase at cargo

Testing

none

🆑
bugfix: Should fix station goals never triggering
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Dec 16, 2024
@Oblisk234

Copy link
Copy Markdown
Member

Could you add "Fixes #22807" to your PR description?

@ShoziOffical

Copy link
Copy Markdown
Contributor

Could you add "Fixes #22807" to your PR description?

can't you link it?

@Oblisk234

Copy link
Copy Markdown
Member

Could you add "Fixes #22807" to your PR description?

can't you link it?

This is not my PR, I cannot edit other people's PR descriptions. That and PRs autoclosing issues makes handling issues easier.

@ShoziOffical

Copy link
Copy Markdown
Contributor

Could you add "Fixes #22807" to your PR description?

can't you link it?

This is not my PR, I cannot edit other people's PR descriptions. That and PRs autoclosing issues makes handling issues easier.

i meant maintainer can link it, why cant you right, i remember maintainer can link pr to an issue

@Oblisk234

Copy link
Copy Markdown
Member

Could you add "Fixes #22807" to your PR description?

can't you link it?

This is not my PR, I cannot edit other people's PR descriptions. That and PRs autoclosing issues makes handling issues easier.

i meant maintainer can link it, why cant you right, i remember maintainer can link pr to an issue

Not sure what you mean?

@ShoziOffical

Copy link
Copy Markdown
Contributor

Not sure what you mean?

image

this was someone else pr

@Oblisk234

Copy link
Copy Markdown
Member

Not sure what you mean?

image

this was someone else pr

That's very odd? Pretty sure it usually doesn't do that, for example how this issue is at present:
image

@ToasterBiome
ToasterBiome merged commit dee3073 into yogstation13:master Dec 20, 2024
Yogbot-13 added a commit that referenced this pull request Dec 20, 2024
@Moltijoe
Moltijoe deleted the StorytellerSendIntercept branch December 29, 2024 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants