Skip to content

fix(root): fixes publish action - #337

Merged
yowainwright merged 2 commits into
mainfrom
fix-action
Oct 2, 2026
Merged

yowainwright merged 2 commits into
mainfrom
fix-action

Conversation

@yowainwright

Copy link
Copy Markdown
Owner

Fixes

  • Fixes issue with publish action

Read about referenced issues here. Replace words with this Pull Request's context.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​shikijs/​rehype@​4.4.3 ⏵ 4.5.01001006996 +3100
Updatedshiki@​4.4.3 ⏵ 4.5.01001007793 -3100
Updatedlucide-react@​1.45.0 ⏵ 1.49.010010098 +196 +180
Updated@​tanstack/​react-router@​1.170.35 ⏵ 1.170.4193 +11008798100
Updatedoxlint@​1.85.0 ⏵ 1.86.099 +110091 +196 +1100

View full report

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (e8b19ac) to head (a413e83).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   96.16%   97.48%   +1.31%     
==========================================
  Files          39       41       +2     
  Lines       14732    14895     +163     
  Branches     2160     2202      +42     
==========================================
+ Hits        14167    14520     +353     
+ Misses        452      322     -130     
+ Partials      113       53      -60     
Flag Coverage Δ
unittests 96.30% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yowainwright

Copy link
Copy Markdown
Owner Author

@greptile

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Updates dependencies and CI workflow for publish action.

This PR appears safe to merge; no actionable issues were found.

What we checked:

  • Override versions agree: All three files select basic-ftp version 6.2.1, so this change does not create conflicting override settings.
Summary

Adds shell lint tool setup before the publish job runs validation.

  • Reuses the shell lint setup already present in CI.
  • Adds a basic-ftp override and records its stated security-fix reason.
  • Refreshes dependency versions and related lockfile entries.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Set up Node and Nub] --> B[Install dependencies]
  B --> C[Set up shellcheck-legibility]
  C --> D[Check release version]
  D --> E[Run validation and build]
  E --> F[Pack and attest tarball]
  F --> G[Publish npm package and release assets]
Loading

Reviews (1) · Last reviewed commit: "fix(root): add packages"

@yowainwright
yowainwright merged commit 2cc9e96 into main Oct 2, 2026
25 checks passed
@yowainwright
yowainwright deleted the fix-action branch October 2, 2026 21:35
@yowainwright
yowainwright restored the fix-action branch October 2, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant