Repository navigation
Fix NumCodecs import with zfpy post-releases - #893
Open
justavibedev wants to merge 1 commit into
Open
justavibedev wants to merge 1 commit into
justavibedev wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
============================================
+ Coverage 89.71% 100.00% +10.28%
============================================
Files 27 27
Lines 914 916 +2
============================================
+ Hits 820 916 +96
+ Misses 94 0 -94
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892.
With zfpy 1.0.1.post0 installed, importing NumCodecs raises a ValueError before the caller can use any codec. This showed up during test collection on #891 and also reproduces with the 0.17.1 release.
The ZFPY compatibility check now uses
packaging.version.Versionfor both packages. The tests cover the released zfpy version, a NumPy local version, and an older zfpy post-release that still needs the compatibility warning.With the actual 1.0.1.post0 wheel, the version, ZFPY and checksum modules had 155 tests pass and seven skip. I also checked importing NumCodecs in an environment without zfpy. The docs built locally with warnings and the new release-note link rendered. Codex assisted with implementation and verification.