You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-ups from the QA and architect passes on PR #216 (#212). None of them block it.
A store skipped for one bad row is silent. List and inject now read through readRuleStore. A store with a single malformed row is read as empty, so all its rules drop out with no warning. In QA's test, one bad row in a 121-rule global store took the listing to 1. synapse_list_rules should say a store was skipped, and a diagnostics line should be written.
PR #221 covers item 1 (synapse_list_rules names a skipped store) and item 3 (no orphan temp file). Still open here:
Item 1, second half: the prompt-injection path (selectInjected) still drops an unreadable store without a trace. Write a diagnostics line, once per process per store, when it is skipped.
Test follow-up from CodeRabbit on PR #221: extend the synapse_list_rules unreadable-store test to corrupt the global store as well, and check that the reply marks the global group as skipped.
Activity
Alter-Igor commentedon Oct 17, 2026
PR #221 covers item 1 (
synapse_list_rulesnames a skipped store) and item 3 (no orphan temp file). Still open here:selectInjected) still drops an unreadable store without a trace. Write a diagnostics line, once per process per store, when it is skipped.Flockpattern from opencode plugin: two processes can spend the same Synapse refresh token #75).bun test test/plugin/observer.test.tsafter an upstream sync.chore(opencode): one doc comment on writeJsonAtomic (#217)
Alter-Igor commentedon Oct 17, 2026
Test follow-up from CodeRabbit on PR #221: extend the
synapse_list_rulesunreadable-store test to corrupt the global store as well, and check that the reply marks the global group as skipped.fix(opencode): synapse_list_rules names a skipped rule store; failed …
fix(opencode): retry a rule-store rename that Windows refuses for a m…
docs(opencode): AGENTS names the Windows rename retry; EACCES is retr…
fix(opencode): rule-store writes take a machine-wide lock; a skipped …