Repository navigation
fix(web): right panel's tab bar no longer slides under the title bar controls - #14
Closed
Claudesaul wants to merge 1 commit into
Closed
Claudesaul wants to merge 1 commit into
Claudesaul wants to merge 1 commit into
Conversation
…controls when it closes
Owner
Author
|
Opened upstream as pingdotgg#26233. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the right panel opens or closes with panel animations on, its tab bar slides under the title bar buttons and draws over them.
Change
The panel's content now stays pinned to the right edge while the panel's width animates. Closing uncovers the chat instead of sliding the content right, so the buttons stay clear. Maximized panels are unchanged.
Scope and approval
A small fix for an obvious visual bug in
PreviewPanelShell.tsx. It does change how the panel animation looks: the content no longer slides, the panel edge sweeps over it.Verification
RightPanelTabstests and theDevicePanelbrowser test pass.vp run dev(dark mode, 300ms panel animation) and stepped the close and open animations frame by frame, before and after. Also checked that maximize still fills the window. Not checked in the Electron window.Model: Claude Opus 5.5. Harness: Claude Code through T3 Code.