Repository navigation
fix(web): right panel's tab bar no longer slides under the title bar controls - #26233
Conversation
…controls when it closes
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The change keeps inline panel content right-aligned during opening and closing so its tab bar avoids the title-bar controls. Its effects are limited to visual layout, with maximized panels and other panel modes unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Align collapsible panel content apps/web/src/components/preview/PreviewPanelShell.tsx |
The wrapper right-aligns collapsible, non-maximized content. The inner panel uses shrink-0 instead of a fixed-width class. Its inline width calculation is unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 856c1
-
No actionable merge-blocking risk remains in the reviewed change.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description follows the template's main sections: Problem, Change, Scope and approval, and Verification. The problem and change are clear, and the verification lists specific checks with observed results, a GIF, and a model/harness line. Two gaps remain. The Scope and approval section gives no link to a triaged issue or maintainer-approved discussion, and it argues the fix is a small obvious bug without linking any approval. The title is not stated in the description, and the Verification section notes the Electron window was not checked, which the template asks authors to state. Overall the description is mostly complete, so it passes.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Note Written by Verified in a real dev environmentverified unchanged head
before, main: after, pr: gif recording: opens/closes, maximize/restore, resizing, file opening, and tab switching. inspected the exported clip and verified uploaded playback to the end and seeking in t3. Not verifiednative electron window controls, macos/windows, ios/android, and relay/tunnel connections were not exercised on this linux web run. other providers were not exercised; this change is client layout only. main completed both codex turns in its provider log but did not render their replies in chat. the exact pr head rendered both replies correctly. this baseline observation was not investigated or changed in this focused verification. |



Problem
When the right panel opens or closes with panel animations on, its tab bar slides under the title bar buttons and draws over them.
Change
The panel's content now stays pinned to the right edge while the panel's width animates. Closing uncovers the chat instead of sliding the content right, so the buttons stay clear. Maximized panels are unchanged.
Scope and approval
A small fix for an obvious visual bug in
PreviewPanelShell.tsx. It does change how the panel animation looks: the content no longer slides, the panel edge sweeps over it.Verification
RightPanelTabstests and theDevicePanelbrowser test pass.vp run dev(dark mode, 300ms panel animation) and stepped the close and open animations frame by frame, before and after. Also checked that maximize still fills the window. Not checked in the Electron window.Recording: a few opens and closes, then zoomed in and frozen mid-close.
Goes with #26232 and #26315: all three clean up the title bar while a panel closes.
Model: Claude Opus 5.5. Harness: Claude Code through T3 Code.