Repository navigation
fix(node): guard loadServices against missing or invalid ime.json (#951) - #952
Merged
Merged
Conversation
- Add getImeBaseDir and parseImeConfig helpers to validate directories and parse ime.json safely - Ensure missing or non-directory entries do not cause ENOENT failures - Handle missing input_methods folder gracefully - Catch JSON.parse and require() errors to prevent crashing the server on startup Previously, any subdirectory in input_methods without an ime.json file or with invalid JSON threw an unhandled exception that terminated the Node.js backend immediately during startup. Generated with assistance from Antigravity (Gemini 3.8 Flash).
Contributor
|
用系統 node v24 直接跑
正常路徑(meow (測試腳本與本留言由 Claude Code (Claude Fable 5.1) 協助產生) |
Member
Author
|
Great defensive hardening for #951. Adding (Review comment generated with assistance from Antigravity + Gemini 3.8 Flash) |
asdf80730
added a commit
to asdf80730/PIME
that referenced
this pull request
Oct 27, 2026
The page is read by agents and humans together, so a stale snapshot misleads both. Issue states re-checked against the GitHub API: EasyIME#936, EasyIME#937, EasyIME#951, EasyIME#966 closed via EasyIME#945/EasyIME#971, EasyIME#946/EasyIME#971, EasyIME#952, EasyIME#976; EasyIME#942's PR EasyIME#972 closed unmerged; rows added for EasyIME#890 and EasyIME#973. The verification-strength table was still claiming no local cargo and 16 Python tests; both layers now run natively through tests/verify_windows.sh, and the launcher, pipes and backends were smoke-tested on this Windows box, so only live TSF hosting remains unverified. Fully generated by omp (Qwen3.8-Flash-Next) without human intervention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #951
Summary of Changes
getImeBaseDirandparseImeConfighelper functions to safely validate subdirectories and loadime.json.fs.existsSynconinput_methodsand return empty array / null gracefully if it does not exist.ime.jsonfiles before reading.JSON.parseandrequire()calls intry...catchblocks with console warnings so invalid modules do not prevent other valid services from loading.loadServiceByIdwith a short-circuit loop once the matching GUID is found.Rationale
Previously, any non-IME folder or corrupted
ime.jsoninsideinput_methodstriggered an unhandled exception (ENOENTorSyntaxError), crashing the Node.js server during startup.Generated with assistance from Antigravity (Gemini 3.8 Flash).