Skip to content

fix(node): guard loadServices against missing or invalid ime.json (#951) - #952

Merged
ottokang merged 2 commits into
masterfrom
fix/issue-951-guard-load-services
Oct 25, 2026
Merged

ottokang merged 2 commits into
masterfrom
fix/issue-951-guard-load-services

Conversation

@PCMan

@PCMan PCMan commented Oct 18, 2026

Copy link
Copy Markdown
Member

Fixes #951

Summary of Changes

  • Introduce getImeBaseDir and parseImeConfig helper functions to safely validate subdirectories and load ime.json.
  • Check fs.existsSync on input_methods and return empty array / null gracefully if it does not exist.
  • Guard against non-directory entries and missing ime.json files before reading.
  • Wrap JSON.parse and require() calls in try...catch blocks with console warnings so invalid modules do not prevent other valid services from loading.
  • Optimize loadServiceById with a short-circuit loop once the matching GUID is found.

Rationale

Previously, any non-IME folder or corrupted ime.json inside input_methods triggered an unhandled exception (ENOENT or SyntaxError), crashing the Node.js server during startup.

Generated with assistance from Antigravity (Gemini 3.8 Flash).

PCMan added 2 commits October 17, 2026 20:33
- Add getImeBaseDir and parseImeConfig helpers to validate directories and parse ime.json safely
- Ensure missing or non-directory entries do not cause ENOENT failures
- Handle missing input_methods folder gracefully
- Catch JSON.parse and require() errors to prevent crashing the server on startup

Previously, any subdirectory in input_methods without an ime.json file or with invalid JSON threw an unhandled exception that terminated the Node.js backend immediately during startup.

Generated with assistance from Antigravity (Gemini 3.8 Flash).
@ilwu

ilwu commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

用系統 node v24 直接跑 node/server.js 驗證 #951 的情境:在 input_methods/ 下另外放三個目錄——空目錄、ime.json 是壞 JSON、ime.json 的 moduleName 指到不存在的檔案——然後送 meow 的 init。

master (1458cea) 本 PR (75738eb)
啟動 SyntaxError: Expected property name or '}' in JSON,exit code 1,連 init 都收不到 三個壞目錄各印一行 warning 後正常啟動,meow init 回 {"success":true}

正常路徑(meow init → onActivate → filterKeyDown)不受影響。

(測試腳本與本留言由 Claude Code (Claude Fable 5.1) 協助產生)

@PCMan

PCMan commented Oct 24, 2026 •

Copy link
Copy Markdown
Member Author

Great defensive hardening for #951. Adding try/catch and existence validation around fs.readFileSync, JSON.parse, and require() ensures that a single unreadable or invalid ime.json will not crash the Node.js backend on startup. Assigned to @ottokang for review. LGTM!

(Review comment generated with assistance from Antigravity + Gemini 3.8 Flash)

@ottokang
ottokang merged commit a818ef0 into master Oct 25, 2026
6 checks passed
@ottokang
ottokang deleted the fix/issue-951-guard-load-services branch October 25, 2026 00:50
asdf80730 added a commit to asdf80730/PIME that referenced this pull request Oct 27, 2026
The page is read by agents and humans together, so a stale snapshot
misleads both. Issue states re-checked against the GitHub API: EasyIME#936,
EasyIME#937, EasyIME#951, EasyIME#966 closed via EasyIME#945/EasyIME#971, EasyIME#946/EasyIME#971, EasyIME#952, EasyIME#976; EasyIME#942's
PR EasyIME#972 closed unmerged; rows added for EasyIME#890 and EasyIME#973. The
verification-strength table was still claiming no local cargo and
16 Python tests; both layers now run natively through
tests/verify_windows.sh, and the launcher, pipes and backends were
smoke-tested on this Windows box, so only live TSF hosting remains
unverified.

Fully generated by omp (Qwen3.8-Flash-Next) without human intervention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js backend: guard loadServices against missing or invalid ime.json

4 participants