Repository navigation
installer: remove obsolete VCRedist bootstrap and inetc (#966) - #976
Conversation
PIMELauncher.exe imports VCRUNTIME140.dll: Rust links the MSVC CRT dynamically by default, so the /MT policy in the root CMakeLists.txt does not cover it. The installer is about to drop its VC++ redistributable bootstrap (EasyIME#966), and the tree ships no vcruntime140.dll outside python\python3, which is not on the launcher's DLL search path. Pass +crt-static through Corrosion and fail the Windows build if dumpbin still reports VCRUNTIME140 or MSVCP140 for the launcher. Generated with assistance from omp (DeepSeek V4.1 Flash).
Windows 10 is the minimum supported OS, so the UCRT is in-box. After the launcher links the MSVC CRT statically (052467d), no shipped binary needs a redistributable DLL: the only vcruntime140.dll is the copy inside python\python3, which the interpreter loads itself. The check tested msvcp140.dll, which no shipped binary imports, and its download aborted offline installs. inetc had no other caller, so drop the plugin and its vendored files along with the function, call site, macro and locale strings. Generated with assistance from omp (DeepSeek V4.1 Flash).
|
This is stacked on #975: removing the redistributable bootstrap only holds once the |
|
This is the correct architectural fix for #966. Since Windows 10 is the minimum supported OS (Universal CRT is in-box), all native binaries link statically with (Review comment generated with assistance from Antigravity + Gemini 3.8 Flash) |
EasyIME#975 (static launcher CRT plus CI dependency gate) and EasyIME#976 (check, macro, locale strings, inetc) merged on 2026-10-24 and EasyIME#966 is closed. Record the merge commits, the now-green per-PR checks, the local makensis replay, and the one remaining gap: the Windows 10 floor is still open as EasyIME#1005. Generated with assistance from omp (DeepSeek V4.1 Flash).
The page is read by agents and humans together, so a stale snapshot misleads both. Issue states re-checked against the GitHub API: EasyIME#936, EasyIME#937, EasyIME#951, EasyIME#966 closed via EasyIME#945/EasyIME#971, EasyIME#946/EasyIME#971, EasyIME#952, EasyIME#976; EasyIME#942's PR EasyIME#972 closed unmerged; rows added for EasyIME#890 and EasyIME#973. The verification-strength table was still claiming no local cargo and 16 Python tests; both layers now run natively through tests/verify_windows.sh, and the launcher, pipes and backends were smoke-tested on this Windows box, so only live TSF hosting remains unverified. Fully generated by omp (Qwen3.8-Flash-Next) without human intervention.
Commit b95d292 (PR #989) accidentally stripped the UTF-8 BOM from installer/installer.nsi (and 3dbea11 / PR #976 from macros.nsh). Without a UTF-8 BOM, makensis.exe treats the script as ANSI and corrupts non-ASCII strings in the installer language menu. Fully generated by Google Antigravity (Gemini) without human intervention.
Summary
The check was a Windows 7/8.1 relic. Windows 10 is the minimum supported OS,
so ucrtbase.dll is in-box. After the launcher links the MSVC CRT statically
(#975), no shipped binary imports a redistributable DLL: the only
vcruntime140.dll is python\python3\vcruntime140.dll, which the interpreter
loads from its own directory. The check tested msvcp140.dll, which no shipped
binary imports, and its download prompt aborted offline installations before
anything was copied.
inetc had no caller outside the deleted macro, so the plugin and its
!addplugindir line go too. StdUtils is a separate plugin and stays.
Depends on #975. Without it, removing this check leaves the launcher without
VCRUNTIME140.dll on a clean machine. Merge #975 first.
Closes #966.
Verification
Fork CI run 39446806581:
build.bat, the launcher dependency gate and makensis all pass. Static
checks: git grep -E 'VCREDIST|vc_redist' -- installer and
git grep inetc -- installer return nothing.
Generated with assistance from omp (DeepSeek V4.1 Flash).