Rename the agent rule Edit tab to Custom by yuwenmemon · Pull Request #105180 · Expensify/App

yuwenmemon · 2026-10-27T21:10:46Z

Explanation of Change

When an admin adds an agent rule, the tab for writing their own rule is labeled "Edit", which reads like changing an existing rule (Slack). This renames it to "Custom", next to "Suggested". Only the label text changes, in all 11 locales.

Suggested tab	Custom tab

Fixed Issues

$ N/A
PROPOSAL: N/A

Tests

Open a workspace with agent rules available and go to Rules.
Open the Agents tab and click Add AI rule.
Verify the two tabs in New rule read "Suggested" and "Custom".
Click "Custom" and verify the rule description box opens.

Verify that no errors appear in the JS console

Offline tests

Same as tests. Only the tab label changed.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Not tested. Copy change only.

Android: mWeb Chrome

Not tested. Copy change only.

iOS: Native

Not tested. Copy change only.

iOS: mWeb Safari

Not tested. Copy change only.

MacOS: Chrome / Safari

chatgpt-codex-connector · 2026-10-27T21:11:00Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T21:20:33.998871Z	`78c48da`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-27T21:11:30Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

carlosmiceli · 2026-10-28T16:05:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

carlosmiceli · 2026-10-28T16:08:00Z

@yuwenmemon maybe merge main for the perf failing test?

…om-tab

OSBotify · 2026-10-28T16:55:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-28T17:30:03Z

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-28T17:35:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105180 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8ae7f62d-812af76-5c1f52000a84b240663d3757f870424c6ede5be2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8ae7f62d-812af76-9283b5ca12991cb7971f0372cdb22c9435d1cee9/index.html

Web 🕸️
https://105180.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-29T01:15:06Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-29T01:20:04Z

Help site update needed. I opened Docs updates for E/A#105180 Rename agent rule Edit tab to Custom.

This PR renamed the Edit tab to Custom. Step 5 in Automate Workflows with Agent Rules still named the old tab:

Choose a pre-written rule from the Suggested list and select Next, or select Edit to write your own rule.

The docs PR changes only Edit to Custom in that sentence. Agent rules are not beta-gated in the App code, so all users see this tab.

@yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-10-29T20:46:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

chore(rules): rename the agent rule edit tab to custom

78c48da

yuwenmemon requested review from a team as code owners October 27, 2026 21:10

melvin-bot Bot assigned yuwenmemon Oct 27, 2026

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 27, 2026 21:10

melvin-bot Bot requested review from carlosmiceli and removed request for a team October 27, 2026 21:11

carlosmiceli approved these changes Oct 28, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into yuwen-agent-rule-cust…

3b5d5a8

…om-tab

yuwenmemon merged commit 8ae7f62 into main Oct 28, 2026
45 checks passed

yuwenmemon deleted the yuwen-agent-rule-custom-tab branch October 28, 2026 16:48

OSBotify mentioned this pull request Oct 29, 2026

Deploy Checklist: New Expensify 2026-10-29 #105309

Closed

73 tasks done

MelvinBot mentioned this pull request Oct 29, 2026

Docs updates for E/A#105180 Rename agent rule Edit tab to Custom #105319

Merged

38 tasks

Navigation Menu

Repository navigation

Rename the agent rule Edit tab to Custom - #105180

Rename the agent rule Edit tab to Custom#105180
yuwenmemon merged 2 commits into
mainfrom
yuwen-agent-rule-custom-tab

yuwenmemon commented Oct 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Oct 27, 2026

Uh oh!

carlosmiceli commented Oct 28, 2026 •

edited

Loading

Uh oh!

carlosmiceli commented Oct 28, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

MelvinBot commented Oct 29, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yuwenmemon commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 27, 2026

Uh oh!

carlosmiceli commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

carlosmiceli commented Oct 28, 2026

Uh oh!

Uh oh!

OSBotify commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

MelvinBot commented Oct 29, 2026

Uh oh!

OSBotify commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuwenmemon commented Oct 27, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 27, 2026 •

edited

Loading

carlosmiceli commented Oct 28, 2026 •

edited

Loading