Repository navigation
Docs updates for E/A#105180 Rename agent rule Edit tab to Custom - #105319
Conversation
Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, focused terminology correction in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.27-0 🚀
|
|
@yuwenmemon No QA steps, OK to checkoff this one? |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.5.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Rename the agent rule Edit tab to Custom renamed the Edit tab in the new agent rule flow to Custom. This made one step in Automate Workflows with Agent Rules incorrect.
Incorrect sentence (step 5 of "How to create an agent rule"):
What changed: the tab label is now Custom (
workspace.rules.agentRules.writeTabinsrc/languages/en.ts), so the step now says "select Custom to write your own rule." No other content changed.Fixed Issues
$ #105180
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@yuwenmemon, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.