Repository navigation
[VID-1603] Document should_retry as RPC-only - #2146
Merged
Merged
Conversation
should_retry on models.Error is meant for RPC responses (retry the same request). The same message is embedded in the websocket error event, where reconnect_strategy decides what the client does; SDKs reading should_retry there (iOS maps true to a FAST reconnect) can override the strategy. The SFU stops setting it on websocket errors (GetStream/video-sfu#1728). Comment-only change; regenerated with the pinned toolchain (protoc v3.21.5, protoc-gen-go v1.28.1). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pojala
approved these changes
Oct 14, 2026
pojala
left a comment
There was a problem hiding this comment.
Approving. Only comments change; the wire format is the same, and the regenerated Go code just realigns the struct fields. Older SFUs still set should_retry on websocket auth errors until GetStream/video-sfu#1728 is deployed everywhere, so iOS needs its fix whatever this comment says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.Error.should_retryis meant for RPC responses:truemeans the client may retry the same request. The same message is also embedded in the websocketSfuEvent.Error, wherereconnect_strategyis what tells the client to reconnect. The proto didn't say so, and SDKs differ:trueinto a FAST reconnect, overriding the strategy.This PR documents the intended meaning. Alongside it, the SFU stops setting
should_retryon websocket errors (GetStream/video-sfu#1728).Changes
models.proto: a comment onError.should_retrysaying it's only meaningful in RPC responses, the SFU never sets it on websocket error events, and clients must followreconnect_strategythere.events.proto: a comment onError.errorpointing toreconnect_strategy.Test plan
go build ./protobuf/video/sfu/...protolint linton both files🤖 Generated with Claude Code